Breeding-Insight / sgn

The code behind the Sol Genomics Network, Cassavabase and BreeDBase websites
https://solgenomics.net
MIT License
2 stars 0 forks source link

[BI-1704] When downloading phenotype data, now returns the most recent #103

Closed davedrp closed 1 year ago

davedrp commented 1 year ago

BI-1704 - If there are repeat measures for a specific observation unit/trait combo, then the phenotype download will return the oldest observation as determined by the collection date of the observation stored in the database. This is inconsistent with a user's expectation that the latest observation be returned in the file.

see Issue 4419

Checklist

timparsons commented 1 year ago

Has this change been discussed with the Breedbase team? If so, maybe we can create another PR to merge upstream.

Yes, https://github.com/solgenomics/sgn/issues/4419 was opened and discussed at their lab meeting a couple of weeks ago. I think we'll need to apply this fix in our develop branch to then be able to push upstream