search

Breeze / breeze.js.samples

Breeze JavaScript Client sample applications
MIT License
96 stars 85 forks source link

Correctly check for PropertyChange action #26

Closed pascalberger closed 9 years ago

pascalberger commented 9 years ago

Currently the check for propertyChange is not working (It compares twice undefined). This PR fixes this. But as consequence stashing no longer happens for newly created ToDo entities, since for them no propertyChange event is raised.

wardbell commented 9 years ago

Well not sure how this slipped by for so long. You fixed ONE of the TWO companion errors ... the other being a few lines above where it said var propChangeAction = breeze.PropertyChange; instead of var propChangeAction = breeze.EntityAction.PropertyChange;

As you noted, if you only make the fix you caught, stashing no longer works. But if we fix BOTH, we're in business.

I fixed both error on our end (see 7815afb0d4) so I won't be able to pull. But THANK YOU for catching this and contributing!