BrenBarn / tabgroupsmanager

Automatically exported from code.google.com/p/tabgroupsmanager
1 stars 0 forks source link

bookmarks bar rendered in wrong place in Firefox 36+ #103

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
In Firefox 36+, when using the Beta 105 (005) version of TabGroups Manager, 
when using the bookmarks bar, the bookmarks bar gets moved to the very top of 
the Firefox window upon Firefox restart. Clicking the Firefox "Customize" 
feature and then closing "Customize" puts the bookmarks bar back in its default 
place, below the URL bar, but users shouldn't need to click "Customize" upon 
each restart. This does not occur when not using TabGroups Manager.

What steps will reproduce the problem?
1. Start Firefox 36.0 with TabGroups Beta 105 (005) enabled and the bookmarks 
bar visible.
2. Watch as the bookmarks bar is placed at the top of the Firefox window.

What is the expected output? What do you see instead?
The bookmarks bar should be placed where it normally goes by default, 
underneath the URL bar.

System Info:
What version of TabGroups Manager are you using?
Beta 105 (005)
What Operative System are you using? 32 or 64 bits?
Windows 8.1 Professional 64-bit
What version of Firefox are you using?
Firefox 36.0
Are you using any other tab extension like Colorfull tabs, Multiple Tab
Handler, TabMix Plus..?
None that affect tabs

Original issue reported on code.google.com by ri...@runbox.com on 3 Mar 2015 at 3:48

GoogleCodeExporter commented 9 years ago
For me bookmark bar is always above TabGroupsManager bar, below the URL bar. 
Please would you mind submitting a screenCapture and other possible extension 
or visual addons or modifications which may be causing the issue?
Thanks.

Original comment by miguelro...@gmail.com on 1 Apr 2015 at 12:52

GoogleCodeExporter commented 9 years ago
Thanks, Miguel!

See attached tgm1.png. This is how Firefox 36+ looks when first launched. The 
bookmarks bar is flung to the very top of the browser window.

If I click the Firefox "Customize" feature and then close "Customize", the 
bookmarks bar is moved to its normal (preferred) location, above the tabs and 
tab groups but below the URL bar. See attached tgm2.png, which shows the 
preferred state.

What is strange is:
1. The bookmarks bar relocates itself just by launching/closing the Customize 
feature, without making any changes to layout.
2. This issue does not occur if TGM is disabled.

Other add-ons I am using that have UI integration where layout may be impacted:
- TabRenamizer-Babar (version 0.9.9)
- SavedSearchButton (version 1.3)
- Open Tabs Next to Current (version 1.0.0)
- Multiple Tab Handler (version 0.8.2015030601)

However, disabling each of these add-ons does not impact this reported issue. 
Only disabling TGM appears to impact this reported issue.

Original comment by j...@brandloyal.com on 1 Apr 2015 at 1:28

Attachments:

GoogleCodeExporter commented 9 years ago
This is related to Australis changes since Fx 29. You can set in TGM options 
tabbar ordinal value to 0, this would be the correct value for Australis. Then 
the tabbar will moved on top and bookmark toolbar does what is expected.

It is not foreseen to change tabbar position since Australis design and the fx 
settings to influence tabs on top was removed. As you can see, your design is 
not consistent due the small free space above the tabbar. TGM can override this 
by changing of ordinal value for tabbar.

Maybe this is also the reason why the bookmark toolbar has now his own behavior 
before and after customize dialog. In fact TGM touches not the bookmark 
toolbar. TGM add only a "ordinal" value to the tabbar to control position of 
groupbar in relation to tabbar.

I'm not sure what is the best solution here. For me it is no option to remove 
the tabbar ordinal settings. I'm self use it in relation with addon classic 
theme restorer to control positions of tabbar and TGM groupbar. And with CTR 
addon all settings makes sense and are also working with bookmark toolbar and 
customize dialog here.

Original comment by micha.go...@arcor.de on 2 Apr 2015 at 7:43

GoogleCodeExporter commented 9 years ago
Hi there - thanks for your help.

Setting the ordinal does not fix this particular issue. The bookmarks bar 
erroneously remains at the top of the screen unless I manually click and close 
"Customize."

Original comment by j...@brandloyal.com on 3 Apr 2015 at 4:22

GoogleCodeExporter commented 9 years ago
The bookmark bar can not stay on top if you change the value for the tabbar to 
0. Then the tabbar is on position 0! Changes of value for groupbar will not 
have any influences to this problem.

Maybe you dont want the tabbar on top but this is the standard case for 
Australis.

You can edit your userChrome.css in chrome folder to take influence to firefox 
self and add following code:

#PersonalToolbar {
      -moz-box-ordinal-group: 80!important;
    }

Original comment by micha.go...@arcor.de on 3 Apr 2015 at 9:25