BrendelGroup / xGDBvm

Code for the xGDBvm iPlant Atmosphere enabled genome annotation platform
http://brendelgroup.github.io/xGDBvm/
GNU General Public License v3.0
0 stars 3 forks source link

Fixed issue with file extensions and CpGAT refrprot documentation #17

Closed standage closed 8 years ago

standage commented 8 years ago

This pull request addresses two issues I encountered trying to get the xGDBvm GUI to recognize the reference protein file I had saved in the appropriate directory.

Also, the addition to the .gitignore file is for temporary files created by Vim.

standage commented 8 years ago

Ok, well the extensions aren't something I have strong opinions on. So if in your experience strictness is warranted, I'd be happy to roll back the changes to XGDB/conf/conf_functions.inc.php and simply document the requirement of a .fa extension.

standage commented 8 years ago

Ok, I rolled back the changes to extension handling and documented the fact that reference protein files must have an .fa extension. It looks like you replaced examples/refpep/cegma_core.fasta with examples/referenceprotein/cegma_core.fa, presumably for the sake of the consistency which you just described, but did not remove the original file. I removed the old copy of the file, and replaced all references to it in the code with references the new file.