Brendonovich / prisma-client-rust

Type-safe database access for Rust
https://prisma.brendonovich.dev
Apache License 2.0
1.74k stars 106 forks source link

Use cargo-binstall for cli #455

Open listepo opened 1 month ago

listepo commented 1 month ago

It would be great to make a prisma-client-rust-cli package via install cargo-binstall

Brendonovich commented 1 month ago

From what I understand cargo-binstall and tools like it require publishing to crates.io, which I won't be doing (https://github.com/Brendonovich/prisma-client-rust/issues/76). If it can support git dependencies then I'll consider it.

listepo commented 1 month ago

searching the linked repository for matching releases and artifacts I thought it was loading artifacts from Github. But I could be wrong

listepo commented 1 month ago

Maybe @NobodyXu can help

NobodyXu commented 1 month ago

Yes, cargo-binstall has --git support, as long as your repository have a Cargo.toml with reppsitory and the version ser, its automatic detection would work

NobodyXu commented 1 month ago

Checking the Cargo.toml for cli, it seems to be missing repository, and its version doesn't match the one is gh release, so if that's updated, amd have pre-built binaries put on github release, it should work.

NobodyXu commented 1 month ago

Checkout our doc for how cargo-binstall automatically discovers gh release artifacts https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md#defaults

listepo commented 1 month ago

@NobodyXu thanks, @Brendonovich is this information useful to you?

listepo commented 1 month ago

@NobodyXu could you help with this task? since you have an understanding of what needs to be done

NobodyXu commented 1 month ago

Basically, you need to: