Closed amodm closed 1 year ago
Currently, string concatenation is used to determine the path to be output for cargo:rustc-link-search=native=, as seen here: https://github.com/Brendonovich/swift-rs/blob/1ca64300e3deedbd47d782d86770d5fc673ffaa4/src-rs/build.rs#L80
cargo:rustc-link-search=native=
So if the package_root argument to link_swift_package does not end with a /, the build breaks, and it's not obvious to the user why that has happened.
package_root
link_swift_package
/
This needs to be changed to use std::path's join mechanism instead of a simple string concatenation.
std::path
join
PR #13 fixes this.
amodm
commented
1 year ago amodm
commented
1 year ago
Currently, string concatenation is used to determine the path to be output for
cargo:rustc-link-search=native=, as seen here: https://github.com/Brendonovich/swift-rs/blob/1ca64300e3deedbd47d782d86770d5fc673ffaa4/src-rs/build.rs#L80So if the
package_rootargument tolink_swift_packagedoes not end with a/, the build breaks, and it's not obvious to the user why that has happened.This needs to be changed to use
std::path'sjoinmechanism instead of a simple string concatenation.