BrentOzarULTD / SQL-Server-First-Responder-Kit

sp_Blitz, sp_BlitzCache, sp_BlitzFirst, sp_BlitzIndex, and other SQL Server scripts for health checks and performance tuning.
http://FirstResponderKit.org
Other
3.35k stars 989 forks source link

sp_Blitz: Check 73 - 'No Failsafe Operator Configured' is skipped when run as sysadmin #3577

Closed Tisit closed 3 days ago

Tisit commented 1 week ago

Version of the script 8.21 - top Github commit

What is the current behavior? Check 73 - 'No Failsafe Operator Configured' is skipped when run as sysadmin

If the current behavior is a bug, please provide the steps to reproduce. Have no failsafe operator configured. Run sp_Blitz as sysadmin. Observe the finding not reported.

What is the expected behavior? The check is not skipped unless explicitly specified

Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures? I'm sure this affects any SQL Server version, but I'm using following: Microsoft SQL Server 2019 (RTM-CU25-GDR) (KB5036335) - 15.0.4360.2 (X64) Mar 19 2024 00:23:01 Copyright (C) 2019 Microsoft Corporation Developer Edition (64-bit) on Windows 10 Pro 10.0 (Build 19045: )

############################################### Not sure, if creating pull request for this immediately is fine for you. It will be basically the same pull request I made previously with fix for the other check removed.

BrentOzar commented 1 week ago

Awesome! Thanks for doing this. Yeah the same fix is totally fine, just standalone.---Tiny glass keyboardTypos flowing like riversAs winter snow thawsOn Oct 8, 2024, at 3:15 PM, Tisit @.***> wrote: Version of the script 8.21 - top Github commit What is the current behavior? Check 73 - 'No Failsafe Operator Configured' is skipped when run as sysadmin If the current behavior is a bug, please provide the steps to reproduce. Have no failsafe operator configured. Run sp_Blitz as sysadmin. Observe the finding not reported. What is the expected behavior? The check is not skipped unless explicitly specified Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures? I'm sure this affects any SQL Server version, but I'm using following: Microsoft SQL Server 2019 (RTM-CU25-GDR) (KB5036335) - 15.0.4360.2 (X64) Mar 19 2024 00:23:01 Copyright (C) 2019 Microsoft Corporation Developer Edition (64-bit) on Windows 10 Pro 10.0 (Build 19045: ) ############################################### Not sure, if creating pull request for this immediately is fine for you. It will be basically the same pull request I made previously with fix for the other check removed.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

BrentOzar commented 3 days ago

Thanks for the pull request! Looks good, merging into the dev branch, will be in the October release with credit to you in the release notes.