search

BrentonCozby / dom-slider

Plain JavaScript version of jQuery's slideToggle(), slideDown(), & slideUp(), but does not use display: none.
MIT License
61 stars 7 forks source link

Conflicting with GSAP's CSSPlugin #1

Closed virajsoni06 closed 4 years ago

virajsoni06 commented 7 years ago

Hey @BrentonCozby, when I load this plugin alongside with CSSPlugin from GSAP it throws a 'classList' of undefined error.

BrentonCozby commented 7 years ago

Hey @virajsoni06 , thanks for the comment. I'll look into it this week.

BrentonCozby commented 7 years ago

@virajsoni06 I'm not familiar with GSAP, but I've included the CDN in a script tag and the error comes from "TweenLite" (GSAP), not dom-slider, so I am unable to figure out what is causing the error.

Please give me more information about the error you see.

virajsoni06 commented 7 years ago

Hey @BrentonCozby, yeah the error is coming from TweenLite. More specifically it happens when clearProps property is used.

I spent some time looking into dom-slider's code and haven't able to figure out exactly whats wrong. But it's likely that it is related to Object.prototype.slideDown function

Will give it a go again sometime next week and see if I can figure out the issue

BrentonCozby commented 4 years ago

Hey, I refactored dom-slider to be an independent module. Its methods are no longer built on the Object prototype chain. These are breaking changes (different API).