BretFisher / php-docker-good-defaults

*WORK IN PROGRESS* sample PHP/Laravel app for Docker examples
MIT License
360 stars 117 forks source link

Move PHP multi-dockerfile to multi-stage build #12

Open BretFisher opened 5 years ago

BretFisher commented 5 years ago

Now that all modern docker versions have multi-stage support, we should migrate the two dockerfiles we currently have to a multi-stage setup:

https://laravel-news.com/multi-stage-docker-builds-for-laravel

vctls commented 5 years ago

Interesting. This guy uses php-apache for the backend. On the other hand, he uses the Composer image and does a COPY from later.
On Sylius-Standard, they just install Composer in the php image. But they use a separate nginx, and they copy the assets to it.