Windows build doesn't print git hash on `--version`

BrettMayson / HEMTT

Build System for Arma 3

https://brettmayson.github.io/HEMTT

GNU General Public License v2.0

109 stars 40 forks source link

Windows build doesn't print git hash on `--version` #277

Closed jonpas closed 1 year ago

jonpas commented 4 years ago

HEMTT Version: 0.7.4 Project: N/A

Description:

hemtt.exe --version -> HEMTT 0.7.3
./hemtt --version -> HEMTT 0.7.3-8df045f
0.7.3 because version was never bumped to 0.7.4 on release.

Steps to reproduce:

Run HEMTT with --version

Additional information:

HEMTT Output:

jonpas commented 4 years ago

Looks like GIT_HASH environment variable just isn't set for Windows compilation, ref.: https://github.com/synixebrett/HEMTT/blob/master/src/lib.rs#L40

BrettMayson commented 4 years ago

Unable to reproduce on Windows, were you using CI builds or locally built?

jonpas commented 4 years ago

That one was a CI build. CI doesn't read the hash as per my last comment.

BrettMayson commented 4 years ago

Tried it with the latest windows builds

Seems there is a different bug, AppVeyor has it twice...

jonpas commented 4 years ago

Can reproduce the same way, not the original bug with 0.7.5. Maybe it was fixed in CI at some point (addition of GitHub Actions?), but this was introduced.

BrettMayson commented 4 years ago

Yeah not sure, nothing has changed in the CI jobs since this issue was created

BrettMayson commented 1 year ago

Closed with 1.0.0, outdated issue