BrettRToomey / Jobs

A job system for Swift backends.
MIT License
294 stars 22 forks source link

Vapor + Jobs error on multiple JSONs #20

Closed syky27 closed 7 years ago

syky27 commented 7 years ago

Hi, I would like to use Jobs, however when I use this:

dependencies: [
        .Package(url: "https://github.com/vapor/vapor", majorVersion: 1, minor: 2),
        .Package(url: "https://github.com/BrettRToomey/Jobs.git", majorVersion: 0)
    ]

I get this from running vapor xcode

No Packages folder, fetch may take a while...
Fetching Dependencies [Failed]
Error: swift-package: error: multiple modules with the name JSON found
fix: modules should have a unique name across dependencies

I know you are using different JSON parser than Vapor, so how can I work around this name duplication?

syky27 commented 7 years ago

I actually only need to use HTTP. So I modified my deps like this

    dependencies: [
        .Package(url: "https://github.com/vapor/engine", majorVersion: 1, minor: 2),
        .Package(url: "https://github.com/BrettRToomey/Jobs.git", majorVersion: 0)
    ]

But I still wonder how can I use both of these JSON deps when I want to use the one that ships with Vapor.

Thanks

BrettRToomey commented 7 years ago

Ahh! Good catch. I think I'll temporarily disable the json dependency and retag. This is mainly a swift package manager issue, but I'll talk with the authors and see what can be done.

syky27 commented 7 years ago

I saw this reported in swift JIRA by Logan I think.

Tomas Sykora

On 2 Dec 2016, at 02:28, Brett R. Toomey notifications@github.com wrote:

Ahh! Good catch. I think I'll temporarily disable the json dependency and retag. This is mainly a swift package manager issue, but I'll talk with the authors and see what can be done.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BrettRToomey/Jobs/issues/20#issuecomment-264348059, or mute the thread https://github.com/notifications/unsubscribe-auth/ACpLWlbhbd0vB-TrBccpXlcmADesfkusks5rD3RBgaJpZM4LCFc6.

BrettRToomey commented 7 years ago

Would you happen to have a link so I can go give it a thumbs up?

syky27 commented 7 years ago

I might have been mistaken the only thing i can find is this https://bugs.swift.org/browse/SR-1195?jql=text%20~%20%22collision%22

Tomas Sykora

On 2 Dec 2016, at 02:33, Brett R. Toomey notifications@github.com wrote:

Would you happen to have a link so I can go give it a thumbs up?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BrettRToomey/Jobs/issues/20#issuecomment-264348911, or mute the thread https://github.com/notifications/unsubscribe-auth/ACpLWqd_u09Y_N4YfzwJCeIvixfBoWuwks5rD3V4gaJpZM4LCFc6.

BrettRToomey commented 7 years ago

Okay, thanks! They need some sort of alias system.

syky27 commented 7 years ago

Yeah, they do.

Tomas Sykora

On 2 Dec 2016, at 02:36, Brett R. Toomey notifications@github.com wrote:

Okay, thanks! They need some sort of alias system.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BrettRToomey/Jobs/issues/20#issuecomment-264349346, or mute the thread https://github.com/notifications/unsubscribe-auth/ACpLWt3iR2k6mGitjZGcjxUIa4J25YgHks5rD3YdgaJpZM4LCFc6.