search

BrettSheleski / SmartThingsPublic

36 stars 23 forks source link

Parent Handler For TasmotaTH #24

Closed Sym-Link closed 5 years ago

Sym-Link commented 5 years ago

Changed details to show Temperature and Humidity. Removed attributes that were not returning any values - friendlyname, group topic, ssid1, ssid2, and up time.

Changed favorites tile to show temp and instead of refreshes, goes to details when pressed.

BrettSheleski commented 5 years ago

Not taking this pull request. Code needs to be refactored. This basically adds the TH functionality into the 'master' device handler.

Instead, a new child device handler should be added to implement specifically the temperature reading, and another child device handler to specifically handle the relative humidity reading. Those two device handlers should do those things and only those things. The existing Tasmota parent device handler would just need to be modified to spawn these two new handlers in when inspecting the module type as well as reading the state of the GPIO configuration.

BrettSheleski commented 5 years ago

Closing as this should be done in a separate pull request making a new device handler as well as modifying the parent device handler.