search

BrettSheleski / SmartThingsPublic

36 stars 23 forks source link

Improvements for ST App Usage #7

Closed GeorgeIoak closed 6 years ago

GeorgeIoak commented 6 years ago

These changes allow the ST app to control and show the proper state of all 4 channels. Unfortunately if a change is made on the Sonoff device those changes are shown in the ST app

BrettSheleski commented 6 years ago

This appears to have renamed the Push(), On(), and Off() functions. This will break the Switch and Momentary capabilities (see https://smartthings.developer.samsung.com/develop/api-ref/capabilities.html#Switch and https://smartthings.developer.samsung.com/develop/api-ref/capabilities.html#Momentary).

The only functional difference I see is when parsing the response for Channel 1, it appears that it should be looking for Power1 instead of simply Power. Make a pull request for that only (without renaming the above) and I will merge.