search

BrettSheleski / comchap

Commercial detection script to add chapters into video file
MIT License
138 stars 26 forks source link

Comcut break if no Commercials #19

Open arrmo opened 7 years ago

arrmo commented 7 years ago

Hi,

It seems like if processing a shorter file, with no commercials => then things break. Or is it just me?

Thanks!

BrettSheleski commented 7 years ago

Could you be more specific of how "things break"?

arrmo commented 7 years ago

Sure! Sorry ... :-(. It seems that then the edl file is empty - that is expected. But then no cut file is generated. That seems OK, but a script no longer sees an output file then.

Or is it just me?

Thanks!

BrettSheleski commented 7 years ago

Still unsure what you're trying to say.

Are you specifying an output file via the command line to comcut? Something like:

comcut /path/to/inputfile /path/to/outputfile

And since inputfile doesnt contain any commercials it is not writing to outputfile?

arrmo commented 7 years ago

Yep, exactly. And as I recall it's erroring out (i.e. returning a fail error code) - but I could be wrong on this one (sorry, remote right now, can't check ... :().

Thanks!

BrettSheleski commented 7 years ago

Gotcha. This should be relatively easy to fix whenever I find time.

arrmo commented 7 years ago

Thanks! Definitely no biggie.