search

BrettSheleski / comchap

Commercial detection script to add chapters into video file
MIT License
138 stars 26 forks source link

changed the if-then statements at the end for better results #29

Closed mgafner closed 5 years ago

mgafner commented 5 years ago

the if-then statements that flags if a file have to be kept or removed are not working in all situations. in my case on Ubuntu 18.10 and bash version 4.3.48(1)-release (x86_64-pc-linux-gnu) i had false positives. see also https://stackoverflow.com/questions/2953646/how-to-declare-and-use-boolean-variables-in-shell-script

in this pull request i changed the statements that way.

mgafner commented 5 years ago

for comcut will be the same. i'll create another pr for that.