search

BrettSheleski / comchap

Commercial detection script to add chapters into video file
MIT License
136 stars 26 forks source link

Add an exit code #35

Open gesa opened 5 years ago

gesa commented 5 years ago

When comcut is part of a larger process, inconsistently creating an output file can cause quite the headache. When exiting with 73, (i.e. EX_CANTCREAT -- A (user specified) output file cannot be created.) subsequent scripts can use that info to prevent trying to work on a non-existent file.

idk this may be a very wrong way to approach my problem—I don't write a lot of pure bash. But I definitely had one of those feelings like "I can't be the only one with this issue" when I was dealing with it so here we are.

BrettSheleski commented 5 years ago

I like the idea of this. In fact I wanted to have useful error codes when first developing this.

What comes to mind is preserving error codes caused by comskip/ffmpeg/etc and return them with a prefix which would be indicative of what part of the process failed.

For example if Comskip returned error code 46, comcut would return 10046.

This is all off the top of my head, there may be a better way.