Reed97123
commented
7 years ago #!/usr/bin/env bash
#LD_LIBRARY_PATH is set and will mess up ffmpeg, unset it, then re-set it when done
ldPath=${LD_LIBRARY_PATH}
unset LD_LIBRARY_PATH
exitcode=0
ffmpegPath="ffmpeg"
comskipPath="comskip"
if [[ $# -lt 1 ]]; then
exename=$(basename "$0")
echo "Add chapters to video file using EDL file"
echo " (If no EDL file is found, comskip will be used to generate one)"
echo ""
echo "Usage: $exename infile [outfile]"
exit 1
fi
comskipini=$HOME/.comskip.ini
deleteedl=true
deletemeta=true
deletelog=true
deletelogo=true
deletetxt=true
verbose=false
lockfile=""
while [[ $# -gt 1 ]]
do
key="$1"
case $key in
--keep-edl)
deleteedl=false
shift
;;
--keep-meta)
deletemeta=false
shift
;;
--verbose)
verbose=true
shift
;;
--ffmpeg=*)
ffmpegPath="${key#*=}"
shift
;;
--comskip=*)
comskipPath="${key#*=}"
shift
;;
--comskip-ini=*)
comskipini="${key#*=}"
shift
;;
--lockfile=*)
lockfile="${key#*=}"
shift
;;
*)
break
;;
esac
done
# Setup for verbose
exec 3>&1
exec 4>&2
if ! $verbose; then
exec 1>/dev/null
exec 2>/dev/null
fi
if [ ! -z "$lockfile" ]; then
echo "lockfile: $lockfile"
while [[ -f "$lockfile" ]]; do
echo "Waiting"
sleep 5
done
touch "$lockfile"
fi
if [ ! -f "$comskipini" ]; then
echo "output_edl=1" > "$comskipini"
elif ! grep -q "output_edl=1" "$comskipini"; then
echo "output_edl=1" >> "$comskipini"
fi
infile=$1
if [[ -z "$2" ]]; then
outfile="$infile"
else
outfile="$2"
fi
outdir=$(dirname "$outfile")
outextension="${outfile##*.}"
edlfile="${infile%.*}.edl"
metafile="${infile%.*}.ffmeta"
logfile="${infile%.*}.log"
logofile="${infile%.*}.logo.txt"
txtfile="${infile%.*}.txt"
if [ ! -f "$edlfile" ]; then
$comskipPath --ini="$comskipini" "$infile"
if [ ! -f "$edlfile" ] || [ ! -s "$edlfile" ]; then
echo Error running comskip. 1>&3 2>&4
if [ ! -z "$lockfile" ]; then
rm "$lockfile"
fi
exit -1
fi
fi
start=0
i=0
hascommercials=false
echo ";FFMETADATA1" > "$metafile"
# Reads in from $edlfile, see end of loop.
while IFS=$'\t' read -r -a line
do
((i++))
end="${line[0]}"
startnext="${line[1]}"
hascommercials=true
echo [CHAPTER] >> "$metafile"
echo TIMEBASE=1/1 >> "$metafile"
echo START="$start" >> "$metafile"
echo END="$end" >> "$metafile"
echo "title=Chapter $i" >> "$metafile"
echo [CHAPTER] >> "$metafile"
echo TIMEBASE=1/1 >> "$metafile"
echo START="$end" >> "$metafile"
echo END="$startnext" >> "$metafile"
echo "title=Commercial $i" >> "$metafile"
start=$startnext
done < "$edlfile"
if $hascommercials ; then
((i++))
echo [CHAPTER] >> "$metafile"
echo TIMEBASE=1/1 >> "$metafile"
echo START="$start" >> "$metafile"
echo END=`$ffmpegPath -i "$infile" 2>&1 | grep Duration | awk '{print $2}' | tr -d , | awk -F: '{ print ($1 * 3600) + ($2 * 60) + $3 }'` >> "$metafile"
echo "title=Chapter $i" >> "$metafile"
if [ "$infile" -ef "$outfile" ] ; then
tempfile=`mktemp --suffix=."$outextension" "$outdir"/XXXXXXXX`
echo Writing file to temporary file: "$tempfile"
if $ffmpegPath -loglevel error -hide_banner -nostdin -i "$infile" -i "$metafile" -map_metadata 1 -codec copy -y "$tempfile" 1>&3 2>&4; then
mv -f "$tempfile" "$outfile"
echo Saved to: "$outfile"
else
echo Error running ffmpeg. 1>&3 2>&4
exitcode=-1
fi
else
if $ffmpegPath -loglevel error -hide_banner -nostdin -i "$infile" -i "$metafile" -map_metadata 1 -codec copy -y "$outfile" 1>&3 2>&4; then
echo Saved to: "$outfile"
else
echo Error running ffmpeg. 1>&3 2>&4
exitcode=-1
fi
fi
if [ ! -f "$outfile" ]; then
echo Error, "$outfile" does not exist. 1>&3 2>&4
exitcode=-1
fi
else
echo Error, no Commercials found, not saving to new location. Nothing to do. 1>&3 2>&4
exitcode=-1
fi
if $deleteedl ; then
if [ -f "$edlfile" ] ; then
rm "$edlfile";
fi
fi
if $deletemeta ; then
if [ -f "$metafile" ]; then
rm "$metafile";
fi
fi
if $deletelog ; then
if [ -f "$logfile" ]; then
rm "$logfile";
fi
fi
if $deletelogo ; then
if [ -f "$logofile" ]; then
rm "$logofile";
fi
fi
if $deletetxt ; then
if [ -f "$txtfile" ]; then
rm "$txtfile";
fi
fi
if [ ! -z $ldPath ] ; then
#re-set LD_LIBRARY_PATH
export LD_LIBRARY_PATH="$ldPath"
fi
if [ ! -z "$lockfile" ]; then
rm "$lockfile"
fi
exit $exitcode
BrettSheleski
The last two nights when comchap was launched through my cron jobs I was surprised to find no chapters in the resulting files. I logged in and tested it again and again and analyzed my code again and again and couldn't find the issue.
Finally it occurred to me that since it was launching through cron the paths weren't setup properly and comchap wasn't flagging it as an error as it ran. I made some changes to comchap to address all the corner cases I found when I went into the script.
1) Comskip doesn't use proper exit codes so I add a check to ensure the edl file has been created and isn't of zero length. Comskip can run successfully, but with a zero length edl as a result and that too must be prevented because it causes the script logic to fail.
Either issues should not allow the script to proceed. The rest of the script is wholly dependent upon the edl file being present and of non-zero length. Because the cleanup for the lock file is at the end of the script I had to replicate the lock file cleanup and exit with error status in the middle of the script.
The way I did this isn't what I'd consider optimal. In Perl (my comfort zone) I would create a error subroutine which I would call in the event of an error. The error subroutine would print the error and it would also perform the file cleanup / removal of lock file, etc. That way the exit and cleanup doesn't need to be replicated multiple times. I'm out of my depth in Bash to do something similar.
2) Adding in a 'echo' that is always displayed (including without verbose) if ffmpeg didn't run successfully.
3) Return the exit code to the OS. You set the '$exitcode' variable, but you never actually exit with that exit code anywhere. I added an exit with the exit code at the end.
4) Added a check that the output file that should have been created is actually present.
5) Removed encoding when no commercials are present. If no commercials are present it should be counted as an error because the main point of running is to detect commercials. Previously it was simply running ffmpeg and copying the streams and acting like it actually successfully ran.
6) Minor code cleanup, removed a redundant outfile assignment. There's no need to do the initial 'outfile' assignment because the conditional that follows assigns it in either case, making the original redundant.