search

Brettflan / WorldBorder

Bukkit plugin for maintaining borders for your worlds to limit their sizes, as well as generating missing chunks or trimming excess chunks.
https://www.spigotmc.org/resources/worldborder.60905/
BSD 2-Clause "Simplified" License
139 stars 210 forks source link

1.13-pre7 Updates #95

Closed javacraft closed 6 years ago

javacraft commented 6 years ago

This PR includes 1.13-pre7 patches we have applied to WorldBorder for our test servers. Feel free to include or use as you see fit.

Brettflan commented 6 years ago

Thanks for the pull request, but...

This project uses Allman indentation style with tabs instead of spaces, as it's my preference from experience in various other languages, rather than the variant of the K&R indentation style used by most Java devs. Since you converted the indentation style of the entire BorderData file in this pull request, it also made the diff become the entire file instead of whatever important bits were substantially changed.

javacraft commented 6 years ago

Using "ignore whitespace" might make things clearer as to the changes. Knowing full well of the style differences, this PR was for a separate branch preview such that it would not muck with master.

As I stated, above "feel free to include or use as you see fit." It should be obvious that the only programmatic change is in your safe teleportation routine. You are more than welcome to cut and paste what you consider important.

The spirit in which this PR was issue was to provide development feedback, hopefully giving you a leg up on 1.13 updates and potentially save you some work or at least spark some ideas.

While I would enjoy a philosophical debate on the merit of various coding styles, I have far more plugins to update and developers to communicate with. You are more than welcome to ignore the information provided by this PR.

Brettflan commented 6 years ago

Using "ignore whitespace" might make things clearer as to the changes.

Yeah, that's helpful, I hadn't seen or used that option before on GitHub. Thanks for pointing it out.

While I would enjoy a philosophical debate on the merit of various coding styles

I wouldn't, I likewise have better things to do.

Thanks again for your intent, some part of this might end up being useful, but definitely not as a pull request with the unnecessary and unwanted sweeping indentation style changes.