search

Brettm12345 / github-moonlight

A beatiful dark blue userstyle for GItHub. Made with :heart:
MIT License
397 stars 12 forks source link

Weird black 1px lines #34

Closed Nuc1eoN closed 4 years ago

Nuc1eoN commented 4 years ago

I have noticed there are several instances where the black 1px border seems to be out of place. for example at the nav bar: image (look bottom left and bottom right)

Then, in the header navbar text, while being in the dashboard: image

In code formatted text: image

And in the footer when in dashboard: image

Brettm12345 commented 4 years ago

I think this has been fixed in the latest release

Nuc1eoN commented 4 years ago

Yes thanks, most of it is fixed! :)

There is still a line, above the 'Marketplace' button though: image

Also, under a closed issue (like this one) there are two lines/separators at the bottom instead of one: image

As a side note, I think it might actually be useful if the "closed issue button" image would also be colored red, just like in the original github theme^^ It could use the same color as the "Closed"-label: image

Nuc1eoN commented 4 years ago

@Brettm12345

There is still a line, above the 'Marketplace' button though: image

Cannot reproduce this one anymore

Also, under a closed issue (like this one) there are two lines/separators at the bottom instead of one: image

This issue is still present (though, it happens only when nothing follows after the "closed" message)

As a side note, I think it might actually be useful if the "closed issue button" image would also be colored red, just like in the original github theme^^ It could use the same color as the "Closed"-label: image

What about this suggestion? Do you think a red button would be valid, or is it supposed to be black? For me it would probably make it pop-out more and make it more easily noticed by the eye.