search

BrewCenter / BrewCenterAPI

An open source api for managing homebrewing related data.
32 stars 11 forks source link

Style/linted according to pep8 #65

Closed JayWelborn closed 7 years ago

JayWelborn commented 7 years ago

I saw some issues you tagged for Hacktoberfest, and while looking through your codebase I linted it to PEP8 standards. I didn't add any code. Everything I changed was related to:

-whitespace -newlines -line length

I also noticed that rest-framework-swagger wasn't included in requirements.txt, so I added that. The install instructions now work as written.

I'd be more than happy to add some tests as well! I love beer and I love python.

MichaelWashburnJr commented 7 years ago

Awesome. Did you use pylint with a custom config file? If you want to provide a custom .pylintrc file, feel free and when I get around to integrating TravisCI I an lint all PRs automatically

JayWelborn commented 7 years ago

I'm kind of embarrassed to admit this, but I just did it manually while I looked through the code. I have a sublime plugin that highlights PEP8 problems and I've gotten in the habit of changing everything as I go.

MichaelWashburnJr commented 7 years ago

haha okay