Beer temperature filter can oscillate when hot plugging a sensor

[elcojacobs]

To reproduce:

• Install a beer sensor in device manager
• Remove power form controller
• Unplug beer sensor
• Power on controller and wait for it to boot
• Plug in beer sensor
• Beer temperature now swings from very high to very low

The cause of this bug: Temperature sensor filters could be used uninitialized due to a bug in the failedReadCounter: when a fridge or beer sensor was plugged in 1-60 seconds after start, the filter was used with uninitialized data and returned invalid temperature.

Fixed in: https://github.com/BrewPi/firmware/commit/3c19c1a672391f7f93f00571e644ea47abdf486a

[elcojacobs]

Should we hotfix this before next release?

[m-mcgowan]

Can you describe the problem in more detail? Releasing a hotfix depends on the nature of the fix. Once the fix is coded, push the fix to a feature branch and we can then decide what to do with it.

[elcojacobs]

A very high result, then a negative result, then very high again and so on. I suspect the filter is not initialized .

[elcojacobs]

Fixed in 0.2.9