BrewPi / firmware

Brewing temperature control firmware for the BrewPi Spark (Particle Photon inside)
http://www.brewpi.com
GNU Affero General Public License v3.0
97 stars 55 forks source link

Feature/wifi #34

Closed etk29321 closed 7 years ago

etk29321 commented 8 years ago

Discovery example:

Scotts-MacBook-Pro:~ sjbaker$ dns-sd -B _brewpi._tcp Browsing for _brewpi._tcp DATE: ---Fri 23 Oct 2015--- 12:02:22.785 ...STARTING... Timestamp A/R Flags if Domain Service Type Instance Name 12:02:22.788 Add 2 4 local. _brewpi._tcp. 1c0031001247343339383037 ^C Scotts-MacBook-Pro:~ sjbaker$ dns-sd -L 1c0031001247343339383037 _brewpi._tcp Lookup 1c0031001247343339383037._brewpi._tcp.local DATE: ---Fri 23 Oct 2015--- 12:02:28.478 ...STARTING... 12:02:28.479 1c0031001247343339383037._brewpi._tcp.local. can be reached at 1c0031001247343339383037.local.:8332 (interface 4) ^C Scotts-MacBook-Pro:~ sjbaker$ dns-sd -q 1c0031001247343339383037.local DATE: ---Fri 23 Oct 2015--- 12:02:35.651 ...STARTING... Timestamp A/R Flags if Name Type Class Rdata 12:02:35.671 Add 2 4 1c0031001247343339383037.local.Addr IN 192.168.8.147 ^C Scotts-MacBook-Pro:~ sjbaker$ telnet 192.168.8.147 8332 Trying 192.168.8.147... Connected to 192.168.8.147. Escape character is '^]'. l L:["Mode Off ","Beer --.- --.- ?C","Fridge --.- --.- ?C","Idling for 49m51"] ^]

gregory-m commented 7 years ago

Judging by all conflicting files you don't plan to merge it.

Any estimates on adding wifi?

Thanks.

etk29321 commented 7 years ago

I don’t have permissions to merge to master. It was relatively conflict free when I did the pull request over a year ago. Elco has had different priorities (e.g. mashing, the rewrite of the base code), so I’ve just continued to use my code that does support wifi personally.

On Jan 2, 2017, at 5:19 AM, Gregory Man notifications@github.com wrote:

Judging by all conflicting files you don't plan to merge it.

Any estimates on adding wifi?

Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://u2283943.ct.sendgrid.net/wf/click?upn=9k8M9RP0aGiPRRX9SknWboKPgLnVUd32WG0wJSR1LwhV9wL6pMMcTluem-2FZf-2Fdx6IlcZtijHx-2FxlUzwmo7o-2BvDiPR2FWhf1Ft06JB7Mj04s-3D_s5UH8bhnBaopYjthcNSRcUYwmzwtrzW-2FqBm93tvfYlHV8Volk4ywwfCXOLguchhJJGwgKXfC0uy8XmmY3dxdOH1wokY5GvG6m9vbbHbVD56hzK3Nt1ttqSsLI-2FhR3UVfpG9U3bQ63OqUE2viygbfNgfiINYu-2BvILYs9aC-2FDiO6zoFP2MxqgQnym-2B20r6xQnpYhQekQ9P-2FnH3NTaECR1BG3JVLAWfCwHP4oIkLbRURdxCoYb5rPlE6X3jDhHyviLXIvPrgqHt523HA-2F2rqBlUk7lY4GmmJy-2B60JWYxOO2f4TTLPbFTxFNNZnDyq7vAw6wt-2BD8Ki1gyshNB7T9-2F3-2Fp2w-3D-3D, or mute the thread https://u2283943.ct.sendgrid.net/wf/click?upn=9k8M9RP0aGiPRRX9SknWbk237b-2BRn8QV9zcjurrBY5Npo7kSSt4rlLp3PEme4DkuE8GRrAnh170yXdEdVF7KbSNck9CG2lyZUbd6uspiUq3OuBgdzR6u8jsobO3azQ1ROZa5ynVVYqQ1YUpw1uaGUA-3D-3D_s5UH8bhnBaopYjthcNSRcUYwmzwtrzW-2FqBm93tvfYlHV8Volk4ywwfCXOLguchhJJGwgKXfC0uy8XmmY3dxdOH1wokY5GvG6m9vbbHbVD56hzK3Nt1ttqSsLI-2FhR3UVfpG9U3bQ63OqUE2viygbfNgfiINYu-2BvILYs9aC-2FDiO6zoFP2MxqgQnym-2B20r6xQnpXiDM5QgTVm1dLIRFBULbAPShr5dHJ3rh0c5cImhDbcuSNnlFNSwEnuSC0ykNPKRkaWz0ik-2FQGy86-2BVNgiB3rWY3lGfdUWEwno4Av6SfutWVqmggy4njDHxNkwa22-2B-2BiPdEQakV0NcVbdhShe25EuJA-3D-3D.

gregory-m commented 7 years ago

Thanks for answer. For me this mean I should chery-pick #54 to your code or to try resolve conflicts.

Both not sounds like much fun.

I have glycol setup and NUC under my TV, buying raspberry PI and spark looks like waste of money to me.

@elcojacobs as far as I understand, you don't have plans to add wifi support before full rewrite (multi chamber support)?

elcojacobs commented 7 years ago

The new version of BrewPi is based on controlbox, a framework for managing objects (sensors, pids, actuators, etc) and getting data in and out of them. We already have WiFi working (with mDNS) in the controlbox branch and this PR has helped us to get that going.

Together with the controlbox switch on the controller, we are also replacing everything that runs on the server. To save ourselves time, we have decided to not add WiFi to the current implementation, but only in the new implementation.