BrewPi / firmware

Brewing temperature control firmware for the BrewPi Spark (Particle Photon inside)
http://www.brewpi.com
GNU Affero General Public License v3.0
97 stars 55 forks source link

Making binaries from elf files fails on CI server #47

Closed elcojacobs closed 7 years ago

elcojacobs commented 8 years ago

When I build the files locally, I get: target/controller-photon/firmware.elf target/controller-photon/firmware.bin

When the files are built by Travis, the logs show that the build tires to make a controller.bin instead of a firmware.bin file and some things go wrong with the CRC handling.

When doing a release, I manually rename the files to: brewpi-0.4.2-photon.bin

I think it would be great that when building, the file name would be: appname-version-platform.bin

Errors on Travis:

~/build/BrewPi/firmware/platform/spark ~/build/BrewPi/firmware
/home/travis/build/BrewPi/firmware/platform/spark
building PLATFORM=core APP=controller
source path /home/travis/build/BrewPi/firmware
using 0.4.2-53-gb3025a6 as build name
stat: head: cannot open `/home/travis/build/BrewPi/firmware/platform/spark/target/controller-core/controller.bin.pre_crc' for reading: No such file or directory
cannot stat `/home/travis/build/BrewPi/firmware/platform/spark/target/controller-core/controller.bin.pre_crc': No such file or directory
head:    text      data     bss     dec     hex filename
cannot open `/home/travis/build/BrewPi/firmware/platform/spark/target/controller-core/controller.bin.pre_crc' for reading: No such file or directory
 108312    2208   10172  120692   1d774 /home/travis/build/BrewPi/firmware/platform/spark/target/controller-core/controller.elf
✓ SUCCESS
m-mcgowan commented 7 years ago

Fixed in 5b6c533d863c6bba9d654619492a3c52b394ebbc