search

BrewPi / firmware

Brewing temperature control firmware for the BrewPi Spark (Particle Photon inside)
http://www.brewpi.com
GNU Affero General Public License v3.0
97 stars 55 forks source link

Making a change in the advanced settings sets "Cooler minimum ON time" 0 #68

Closed n8huntsman closed 7 years ago

n8huntsman commented 8 years ago

If I set my minimum on time, send to core, then update from core to verify setting, it appears correct. However, making any other changes, such as max difference or Beer-to-Fridge proportional gain (Kp), then clicking update from core, resets the min on time to zero.

elcojacobs commented 8 years ago

Bug confirmed. Thanks for reporting it.

Setting the beer-to-fridge max difference causes the minimum on time to become zero.

Tested on the Photon, 0.4.3

elcojacobs commented 8 years ago

Related to what is fixed here:

https://github.com/BrewPi/firmware/commit/f96965e3ef065449a97883670555ad90b0e1ed37

The min cool time is in EEPROM/memory just after the max difference: https://github.com/BrewPi/firmware/blob/master/app/controller/TempControl.h#L67

This is why it gets overwritten when applying the max difference with the wrong data length.

I could not reproduce it when changing Kp, it seems to only happen with the max difference.

elcojacobs commented 7 years ago

fixed in 0.4.4