Touch screen calibration is sometimes triggered, even when a calibration has been stored earlier

BrewPi / firmware

Brewing temperature control firmware for the BrewPi Spark (Particle Photon inside)

http://www.brewpi.com

GNU Affero General Public License v3.0

97 stars 55 forks source link

Touch screen calibration is sometimes triggered, even when a calibration has been stored earlier #8

Closed elcojacobs closed 9 years ago

elcojacobs commented 9 years ago

It should be investigated what causes this. Is the value in EEPROM invalid? Is it not stored correctly or not read correctly?

This is a problem when there is no physical access to the controller: while in the calibration screen, the controller cannot be controlled remotely. We could add a timeout, with a warning over serial.

m-mcgowan commented 9 years ago

I investigated this with 2 external flash images from the community, and both were fine.

I erased external flash - powered on and the device wanted to calibrate.
Flashed each of the community images to my device, the device did not need to calibrate, indicating the images were fine.

The suspected cause is a rogue 't' command being sent to the device, which will cause the device to jump into calibration mode.

We will remove serial calibration mode in the next release when we have a boot menu to allow calibration.

m-mcgowan commented 9 years ago

It turns out to be the script sending a 'T' command. For 0.2.8, we have removed this command since recalibration is available via tapping the screen during startup.