BrewPi / firmware

Brewing temperature control firmware for the BrewPi Spark (Particle Photon inside)
http://www.brewpi.com
GNU Affero General Public License v3.0
98 stars 55 forks source link

Refactor lib tests to use catch BDD scenarios #89

Closed oyvindh closed 6 years ago

oyvindh commented 6 years ago
CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

oyvindh commented 6 years ago

This is meant for getting early feedback. No quite ready for merging yet.

oyvindh commented 6 years ago

@elcojacobs: I thought I signed the CLA a long time ago? Let me know if I need to do it again

elcojacobs commented 6 years ago

It should be signed for each repo you contribute to I think. You probably signed it for another repo. I can see if that can be simplified.

elcojacobs commented 6 years ago

The library classes have been refactored a lot and have new catch tests, so this PR is outdated.