search

Brewskey / spark-protocol

Node.JS module for hosting direct encrypted CoAP socket connections
GNU Lesser General Public License v3.0
9 stars 16 forks source link

Download all firmware releases. #143

Closed brahma-dev closed 5 years ago

jlkalberer commented 5 years ago

The PR looks fine but why don't you want to include RCs? It really shouldn't affect anything if they are downloaded as well.

brahma-dev commented 5 years ago

I remember it being that way. https://github.com/Brewskey/spark-protocol/blob/620d7acba9ef38aafa76f2be73937c98263c433b/src/scripts/update-firmware-binaries.js#L192

But I can remove the filter if you say so.

jlkalberer commented 5 years ago

Yeah, I think I removed them but added them back in because there wasn’t a good reason to filter. Generally I use ParticleDev and you can flash any version to your device. If you don’t have a good reason to filter them then let’s just keep everything.

Other than that, thanks for the diff!

brahma-dev commented 5 years ago

@jlkalberer Done.