search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 135 forks source link

[OSX] Crashes when run directly from DMG (read-only installer image) #269

Closed BradRobinson9 closed 3 years ago

BradRobinson9 commented 8 years ago

I downloaded Brewtarget for the first time today. A screen pops up saying "multiple databases were found. Do you want to restore the changes you made during your last Brewtarget session, or rollback to before last session's changes"

ive never used this program, and it crashes as soon as its open

help?

xor-gate commented 8 years ago

Maybe you could provide your version and operating system?

mikfire commented 8 years ago

MacOS based on the crash report.

If I am reading it right, it looks like we did a recalcAll and are trying to write the changes to disk, and that is causing a panic.

I don't know enough about Mac to be much more help, but I would first make sure you have write access to where ever the database lives on Mac, or where ever /Volumes/VOLUME/Brewtarget.app/Contents/MacOS/Brewtarget is.

Mik

On Wed, Jun 1, 2016 at 3:27 PM, Jerry Jacobs notifications@github.com wrote:

Maybe you could provide your version and operating system?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Brewtarget/brewtarget/issues/269#issuecomment-223098822, or mute the thread https://github.com/notifications/unsubscribe/AKxgF-BvPiKDvQXjE7AMZlEAgbyDoEShks5qHd0hgaJpZM4Ip7k9 .

In a world of ninja v. pirate, I pilot a Gundam

xor-gate commented 8 years ago

I think the DMG (disk image) is mounted (read-only) at /Volumes/<VOLUME>/........ then Brewtarget is run straight from the DMG which probably causes the panic.

xor-gate commented 8 years ago

Probably some sanity checks should be made before writing so it wont crash or notify the volume is read-only.

rocketman768 commented 8 years ago

@BradRobinson9 in case it's not clear, drag the Brewtarget icon from the .dmg image into your Applications folder to install. Then you can open it from Applications.

matty0ung commented 3 years ago

Is there, in fact, anything to do on this bug? It seems the way this part of the code works was already changed and the error message reported by the bug raiser is no longer in the current code. (It was originally in Database::cleanupBackupDatabase() - see https://github.com/Brewtarget/brewtarget/blob/stable/2.2.0/src/database.cpp - but this function no longer exists in the 2.4 code.)

mattiasmaahl commented 3 years ago

Closing, issue solved in unknown PR/FIX