search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 135 forks source link

Rebalances the water editor #556

Closed mikfire closed 3 years ago

mikfire commented 3 years ago

The water editor was always kind of unpleasant to look at, but I couldn't figure a better way. With the addition of the radar map, I could no longer ignore it and I had a better way.

It still isn't perfect, but this somewhat more digestable.

matty0ung commented 3 years ago

Another newbie question: If I want to download your patch and compile/run it locally, how do I do that?

xzfantom commented 3 years ago

Another newbie question: If I want to download your patch and compile/run it locally, how do I do that?

The easiest way that I found - use Github Desktop. When choosing current branch it shows available pull requests and makes all stuff. Another way is to add mikfire as git remote and switch to mikfire:feature/watereditor

mattiasmaahl commented 3 years ago

Sorry for short answer, on the phone.You run " git fetch upstream pull//head:"Then git checkout I.e. git fetch upstream pull/536/head:somebug git checkout somebug

Easiest way I know of.

mikfire commented 3 years ago

I use one of two, depending on the complexity of the change.

You can git clone my repo, switch to the right branch, build and run.

If the change is isolated, like this one, you can make your own branch, copy the one file into place, build and run.

I tend to use the first a lot, because it's just easy, I've got good bandwidth and a lot of disk space.

mikfire commented 3 years ago

No. I didn't intend on mucking the tab order up.