search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 135 forks source link

Partial fix for inventory bug #602

Closed matty0ung closed 3 years ago

matty0ung commented 3 years ago

This stops the crashing reported in https://github.com/Brewtarget/brewtarget/issues/601, but doesn't fix the problem that not everything has an inventory ID. (This is fixed in Brewken because, when I rewrote the DB layer, I added some logic that automatically creates an inventory ID for anything that doesn't have one. That fix will get backported soon, I hope, when I backport the new database layer.)

mattiasmaahl commented 3 years ago

Looks good, also compiles on my machine, although I had to install Boost libraries. So we have to modify the checks/actions to accommodate this new library. that is a small issue though.

matty0ung commented 3 years ago

Thanks. You could comment out the Boost include if it came to it. It's just for debugging. But I think there's a good chance we will end up using another bit of Boost for BeerJSON, so it's worth having it in the build.

mattiasmaahl commented 3 years ago

That's what I thought. I have a fix on its way. Creating PR as we speak.