Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 135 forks source link

We currently display a Recipe's date as "Brew Date", when it should probably be "Creation Date" #619

Closed matty0ung closed 3 months ago

matty0ung commented 2 years ago

See https://bugs.launchpad.net/brewtarget/+bug/1898188 that when you copy a recipe it looks like its brew date is copied too.

Actually, in Recipe itself, the attribute is just called date and there's a comment saying The date the recipe was created or brewed. I'm not sure yet.

I suggest we either not display a Recipe's date or display/treat it as date created.

Creating a new recipe already sets its date to whatever the current date is. And we have a separate data structure (BrewNote) for recording the occasion(s) on which a recipe was brewed. So it's not like we need a recipe record to have its own brew date.

matty0ung commented 3 months ago

Fixed in https://github.com/Brewtarget/brewtarget/pull/798