search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 134 forks source link

Fixed efficiency #641

Closed ghost closed 2 years ago

ghost commented 2 years ago

Hello there :) I used to be able to change the value of the expected efficiency in the window composing a recipe. Now the value is fixed at 70% and cannot be changed. I'm using the latest version from git on linux. Does anyone else have a similar problem?.

Have a good one.

matty0ung commented 2 years ago

Hi, Thanks for the bug report. I can confirm I can reproduce this. I'll have a look at the cause.

matty0ung commented 2 years ago

OK, I think I have a fix. BtLineEdit::onLineChanged() needs to emit textModified() in the event that the field does not hold a physical quantity. I've tested it on my local install and it seems to do the job. It's a small change. I'll do a patch either tonight or tomorrow morning.

matty0ung commented 2 years ago

Patch uploaded at https://github.com/Brewtarget/brewtarget/pull/642. Awaiting review.

ghost commented 2 years ago

Wow that was quick!. I just recompiled it and it works flawlessly. That bug got terminated. Thank you so much :)).