search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 134 forks source link

Build fixes etc for Release 3.0.0 (was 2.4.0) #655

Closed matty0ung closed 1 year ago

matty0ung commented 2 years ago

I've changed CMakeList.txt, src/CMakeList.txt and QtDesignerPlugins/CMakeLists.txt so that all the build logic and settings are in the first of these 3 files, and the latter 2 just contain lists of source files.

I've turned on more of the CMAKE_AUTOxxx settings and removed all the (now unnecessary) places where we were manually listing .ui files and .h files that need MOC processing etc.

Still in CMakeList.txt, I've tried to put things together that go together and improve commenting. For Linux, I've also got package building (make package) and package lint (make package_lint) seemingly working, but it could do with some proper testing. Will probably need some help getting Windows and Mac packaging working, as I'm currently just pushing commits up to github to see what happens when I change those bits of CMake/CPack, which isn't very productive... :smile:

On Linux the build process now takes CHANGES.markdown and converts it to a Debian-format changelog that can be included in the .deb package. (The lintian program is quite strict about formats, so there's a bit of not-very-pretty scripting here. It also doesn't like spelling mistakes, so I've corrected a couple of typos in issue descriptions!)

CHANGES.markdown mentions all the closed issues that were modified since the last release in 2016. Could probably do with going through that and filtering out ones that were closed without code change.

Have also:

mattiasmaahl commented 2 years ago

Will try to get windows build tested during the week. Will revert.

matty0ung commented 1 year ago

Still fighting with the Windows build. I've managed to get the build process itself not to barf out obscure errors (by which I mean errors that nobody else seems ever to have reported having!), but I haven't yet worked out how to get make install to put all the DLLs in the right place.

matty0ung commented 1 year ago

I think this is now working. If anyone has time to check the Windows and/or Mac packages, that would be great. If not, we could at least push the Linux release live and then do any further fixes in 3.0.1.

matty0ung commented 1 year ago

Eliminated the need to run make changelog as a separate step. Builds are now producing some sort of package on all 3 platforms. Merging everything so we can do the release.