search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 134 forks source link

Turkish Language selection in settings not working #670

Closed smntsn closed 1 year ago

smntsn commented 1 year ago

First of all I'm using this great software about 2 years and I LOVE IT :) THANK YOU :) My problem is (also for 2x versions) Turkish language selection changes nothing (Interface still in English). I fixed it by downloading Turkish translation>converting to .qm with QtLinguist and replacing it in installation folder(for 2x version).

But, now I can't do it.

I don't know if supplied "bt_tr.qm" is not Turkish or setting page language selection is not working.

Thanks in advance.

Ekran görüntüsü 2022-10-19 174931

matty0ung commented 1 year ago

I will take a look at this.

matty0ung commented 1 year ago

OK, so I've fixed the build so that it is properly synchronising the "translations/*.ts" files (ie translation source files) with the translatable strings in the source code. Once this fix is merged, you should be able to make useful edits to translations/bt_tr.ts.

I don't know whether generating the .qm file from QtLinguist and manually installing it is always guaranteed to work, but either way if you share your translations with us then we'd be very happy to incorporate them in the main build.

matty0ung commented 1 year ago

For now, I've put a "placeholder" translation in for "About Brewtarget" so it says "Turkish for about Brewtarget". This means that, by showing the "About" dialog, we can convince ourselves that "display in Turkish" is picking up strings from the right place.

Once we have some Turkish translations in https://github.com/Brewtarget/brewtarget/blob/develop/translations/bt_tr.ts then we won't need that placeholder.

matty0ung commented 1 year ago

Sorry, jumped the gun a bit. Wait for https://github.com/Brewtarget/brewtarget/pull/672 to be merged.

matty0ung commented 1 year ago

We'll do a 3.0.2 release soon, which will contain the fixes mentioned above.

matty0ung commented 1 year ago

The 3.0.2 release is now out, so I'm closing this ticket. But please don't hesitate to re-open it (or raise another issue) if you hit problems with that new release.