search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 134 forks source link

Do we need changedFolder signal? #707

Open matty0ung opened 1 year ago

matty0ung commented 1 year ago

Following on from https://github.com/Brewtarget/brewtarget/issues/703, I see we declare changedFolder signal on NamedEntity but I can't find anywhere in the code where we actually emit this signal.

Is it something old that we can remove? Or is something currently broken because this signal isn't getting sent?

mikfire commented 1 year ago

I am honestly uncertain. Everything with folders seems to work, although I cannot drop a folder onto another folder. I would need to build the old code to remember if that feature worked or not.

Half a neuron is suggesting I wrote that expecting to need it, and then realized it wasn't needed. Since folders only ever existed in trees, I could simply call the folderChanged() method directly and not muck about with signals.

Let me pull the old code into a vm tomorrow and make sure of a few things. I will comment the connect in BtTreeModel out and see what breaks.