search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 134 forks source link

Hop editor crashes App #717

Closed Melonbob closed 1 year ago

Melonbob commented 1 year ago

The installed default database from developer branch builds doesn't coincide with the DefaultData.xml at least with hop records. The db is leaf and the xml is pellets. How do I rebuild it from the xml?

Also when I went to edit with the Hop editor window, the pull-down menus were duplicated. The top set crashes the App while the bottom set does not.

image1

image2

image3

matty0ung commented 1 year ago

Ooh, I thought I'd fixed this, sorry. It's a bug caused by when I accidentally brought to much of the "in development" BeerJSON work into the dev branch. I'm travelling at the moment but will try to get a fix in the coming week.

matty0ung commented 1 year ago

So I've done a fix for the UI bit. The data import bit probably needs a bit more looking at. Do you see any errors in the logs when you start up with a clean database? What is supposed to happen is that the code should read the contents of DefaultData.xml into the DB using the regular XML import process. If that fails for some reason then, usually, there should be some error message in the logs.

(The reason all this is being changed for BeerJSON is that it recognises additional forms of hops (Extract, Wet Leaf and Powder) that don't exist in BeerXML and therefore we didn't previously support.)

Melonbob commented 1 year ago

I put the log here from startup here. Looks like a clean, normal startup. https://github.com/Brewtarget/brewtarget/issues/714#issuecomment-1418141222

Melonbob commented 1 year ago

My MSYS2 MINGW32 package build with the current upstream has resolved this. See also: https://github.com/Brewtarget/brewtarget/issues/711#issuecomment-1419309078