Also a bit more work on the Mac build/packaging trying to fix this library-not-found-even-though-it's-there issue. (Including realised the final step of the Mac packaging was creating an empty .dmg file, which this fixes.)
Also tidied up a few comments.
(I meant this to be two separate PRs, but did things in the wrong order on github.)
NB: I think the changes I've done on looking up unit names slightly change the behaviour when you enter an ambiguous unit name. Eg, if you type '5 gal', there is sometimes no way for us to know whether you mean US gallons or Imperial gallons - eg because you are using the free-standing conversion tool or you have configured a field's default units to be metric. At the moment, if there are no other clues to follow, you get whichever type of gallon the program happens to find first, which might be different than in previous versions of the software. I don't use gallons (of either sort) myself, so, if anyone who does wants to tell me how the behaviour should be different, then I would be very happy to hear it.
This is for https://github.com/Brewtarget/brewtarget/issues/725
Also a bit more work on the Mac build/packaging trying to fix this library-not-found-even-though-it's-there issue. (Including realised the final step of the Mac packaging was creating an empty .dmg file, which this fixes.)
Also tidied up a few comments.
(I meant this to be two separate PRs, but did things in the wrong order on github.)
NB: I think the changes I've done on looking up unit names slightly change the behaviour when you enter an ambiguous unit name. Eg, if you type '5 gal', there is sometimes no way for us to know whether you mean US gallons or Imperial gallons - eg because you are using the free-standing conversion tool or you have configured a field's default units to be metric. At the moment, if there are no other clues to follow, you get whichever type of gallon the program happens to find first, which might be different than in previous versions of the software. I don't use gallons (of either sort) myself, so, if anyone who does wants to tell me how the behaviour should be different, then I would be very happy to hear it.