search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
312 stars 134 forks source link

"Brew it" self-closing tab #730

Open Jazzbeerman opened 1 year ago

Jazzbeerman commented 1 year ago

It seems that I am becoming a tester (and this is good, because maybe my information can be useful). A small annoying feature. It lies in the fact that if you click "Brew it", a new tab will be formed. If you are lucky, then you can edit it without any inconvenience. But it often happens to me that after entering the measurement results in any text field, the tab closes, and I find myself back on the recipe page. You have to re-open the tab with the brew date, enter the next value, and then spontaneously close again. In total, in order to enter data about the state of the postboil, you will have to open the tab 4 times. This is, of course, annoying at times. What is the reason for this behavior - I do not know, maybe my problem is single. In this case, the data is entered, saved, etc.

matty0ung commented 1 year ago

Yes, more testing is good!

From a very quick look I can't instantly reproduce what you're seeing, but that may not be surprising if it's something that happens a bit randomly. Does the tab disappear completely, or do you just get switched back to the main recipe tab? Either way it shouldn't happen.

It's also true that the layout doesn't work that well on my HDPI screen, so when I get to tweaking that I'll see if I can get the same thing to happen on my machine.

Jazzbeerman commented 1 year ago

Quite right, the problem appears quite often, but still not 100% of cases. Yes, you are absolutely right, the tab closes and I find myself in the main recipe menu. However, in order to open the tab again, I have to call it from the left panel (where the list of recipes is). At the same time, it will disappear in the main panel (that is, three tabs will be visible, Recipe, Extras and Brewday)

matty0ung commented 1 year ago

That sounds annoying. Let me get to my next rest point on BeerJSON and then I'll try to take a proper look. Depending on how easy it is to reproduce locally, we might add some more diagnostics to the code.