search

Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
310 stars 134 forks source link

"Brew it" crashes Mac app #747

Closed 95ep closed 1 year ago

95ep commented 1 year ago

Was a bit quick to say that the latest Mac build works, seems like there still are some problems with the Mac build unfortunately

Whenever I hit the "Brew it" option for a recipe the app crashes, see screenshot. The log message seems rather generic.

[16:16:03.000] (3yz8k1s) WARNING : Qt has caught an exception thrown from an event handler. Throwing
exceptions from an event handler is not supported in Qt.
You must not let any exception whatsoever propagate through Qt code.
If that is not possible, in Qt 5 you must at least reimplement
QCoreApplication::notify() and catch all exceptions there.
  [:0]
Screenshot 2023-05-01 at 16 16 24
matty0ung commented 1 year ago

Will investigate. From a quick look, the "good" news is that I can reproduce this on Linux.

matty0ung commented 1 year ago

This is because I left some old code in the "digit widget" class when I refactored the "display amounts" code. I have a fix working locally. Will do a PR for that and for https://github.com/Brewtarget/brewtarget/issues/748.

matty0ung commented 1 year ago

Should be fixed in https://github.com/Brewtarget/brewtarget/releases/tag/v3.0.9. Please re-open if not!