Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
310 stars 134 forks source link

Plugins for add new content #750

Open kalilbispo opened 1 year ago

kalilbispo commented 1 year ago

First of all, thank you so much for your app.

This is not an issue or a bug, but rather a suggestion. Could you please add plugins to Brewtarget that allow users to add new content such as:

I believe that using plugins to add content would be preferable to doing it manually

matty0ung commented 1 year ago

Glad you're finding Brewtarget useful.

When you say "plugins", do you mean a way to import styles and yeasts and so on from another program? Or is it something else? If you could give an example that might be helpful for me to understand.

You can currently import things from BeerXML (mostly, though there are some inherent problems with BeerXML that sometimes make this a bit fiddly).

In the not too distant future (I hope), it will be possible to import things from BeerJSON. (I have it working for Hops and Fermentables, and am slowly working through the other importable things!)

kalilbispo commented 1 year ago

When I used the term 'plugin,' I was referring to a user-friendly and developer-friendly solution. Specifically, I envision a feature where users can easily import Swaen, Agraria, or BestMalz into their malt list by simply clicking a button within the program itself, without the need for BeerXML or even external solutions.

matty0ung commented 1 year ago

So you'd like to be able to import all the malts from a particular maltster at the click of a button? That would be a neat feature :smile_cat: but it might be a bit tricky without the cooperation of all the maltsters to make their data available in a common format. (IDK if they could be persuaded on the grounds that it is for the benefit of their customers.)

Alternatively, maybe, if it turned out that all malt spec sheets were sufficiently similar, there might be a clever way to parse them with BeautifulSoup, Scrapy or some such. Depending on how "standard" the spec sheets are, it could turn out to be a bit fiddly to write though. If it were feasible, and someone had the time to tackle it, I would think the best approach IMHO would be to code a free-standing external tool that converts spec sheets into BeerJSON and then have Brewtarget ingest that. But, as ever, am open to suggestions.

kalilbispo commented 1 year ago

I think I can help you in this task

Kalilovisky commented 1 year ago

Dear Matt, I am writing to inform you that I have sent you an invitation to join my GitHub project. I would greatly appreciate your feedback on the BeerJSON tool and whether you think it meets our requirements. https://github.com/Kalilovisky/BeerJSON_Tool_for_Brewers

matty0ung commented 1 year ago

Definitely looks like a good idea if you already have all the data in spreadsheets.

If you have data for Hops or Fermentables, then we can already try importing it. I usually find with these sorts of things that it's quite an iterative process getting the parsing and writing working.

Kalilovisky commented 1 year ago

New Hop Strains (318) added in the project

Em qui., 11 de mai. de 2023 às 03:29, Matt Young @.***> escreveu:

Definitely looks like a good idea if you already have all the data in spreadsheets.

If you have data for Hops or Fermentables, then we can already try importing it. I usually find with these sorts of things that it's quite an iterative process getting the parsing and writing working.

— Reply to this email directly, view it on GitHub https://github.com/Brewtarget/brewtarget/issues/750#issuecomment-1543411078, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUIGOP4PHUFCMMD4EIGPLTXFSBONANCNFSM6AAAAAAXZ6QUPA . You are receiving this because you commented.Message ID: @.***>

-- Kalil Araujo Bispo PhD in Computer Science Computing Department, UFS, Brazil