Closed marker5a closed 1 year ago
Ah, good spot, and, yes, that's a good fix. (Alternatively, if we wanted to be super pedantic about the fact that there should never be a negative number of fermentation stages, then, in model/Recipe.h
, we could make fermentationStages
an unsigned int
property, with the corresponding changes to its getter and setter, but I'm not sure if that would be worth the hassle.)
AFAICT this is a property that we don't currently expose in the UI, but I'm hoping/expecting to change that as part of the BeerJSON work.
If you want to do a PR, I'll happily approve it.
Otherwise I'll include the fix in whatever the next commit is.
Ok, cool, I'll do a PR for it momentarily
On Mon, Jul 3, 2023 at 2:30 PM Matt Young @.***> wrote:
If you want to do a PR, I'll happily approve it.
Otherwise I'll include the fix in whatever the next commit is.
— Reply to this email directly, view it on GitHub https://github.com/Brewtarget/brewtarget/issues/760#issuecomment-1618984437, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSNTYIMRW6IHYIVFYSKIPTXOMFWFANCNFSM6AAAAAAZ4YT2RI . You are receiving this because you authored the thread.Message ID: @.***>
PS: I do half expect you to find other PostgreSQL issues, because it's a bit less fast-and-loose about things than SQLite. They should all be fixable though!
Yeah, totally understandable. I'm planning on moving over to postgres for brewtarget, so hopefully I'll uncover the bugs :)
On Mon, Jul 3, 2023 at 3:02 PM Matt Young @.***> wrote:
PS: I do half expect you to find other PostgreSQL issues, because it's a bit less fast-and-loose about things than SQLite. They should all be fixable though!
— Reply to this email directly, view it on GitHub https://github.com/Brewtarget/brewtarget/issues/760#issuecomment-1619016621, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSNTYKD5Z3CN4GFUOAFZADXOMJLXANCNFSM6AAAAAAZ4YT2RI . You are receiving this because you authored the thread.Message ID: @.***>
Should be fixed in PR #762
This fix is included in in https://github.com/Brewtarget/brewtarget/releases/tag/v3.0.10.
I setup a fresh postgres14 instance w/ an empty schema and connected a fresh install of brewtarget to the database through the settings page. After connecting successfully and presumably setting up the schema and init data, it prompted me to restart.
After exiting, Brewtarget will no longer startup and it returns the following assertion log:
From looking at the code, it looks to just be a typecast issue... I changed it on my working copy and it seems fine...