Brewtarget / brewtarget

Main brewtarget source code repository.
GNU General Public License v3.0
313 stars 134 forks source link

Fix for crash when editing fermentation ages #786

Closed matty0ung closed 8 months ago

matty0ung commented 8 months ago

Fix for https://github.com/Brewtarget/brewtarget/issues/785

The fermentation age fields are handled a bit differently than most other ones. Although they are a measure of time (duration), we actually treat them as raw numbers because we're only measuring to the nearest day, and don't want to start offering to show things in hours/minutes/seconds etc. The bug was we were saying "convert this field to its standard units of measurement" when we should have been saying "get this field as a raw number".

EDIT: Fighting a bit to get the Windows build working. Turns out some of the 32-bit MSYS2 packages/groups we were relying on previously are no longer available. (Works on my local machine because they are already installed, but not on GitHub Actions because there you install from scratch each time.) Will have a look at whether we can get 64-bit Windows build working.