search

Brian0255 / NDS-Ironmon-Tracker

An ironMON tracker for Nintendo DS Pokémon games.
GNU General Public License v3.0
39 stars 16 forks source link

Linux updater #81

Closed wesleystedman closed 1 year ago

wesleystedman commented 1 year ago

So I've tested this a little and it works, but Zac and Fellshadow have me doubting that it's rock solid. It comes down to if bizhawk somehow stops us from overwriting a file, which... I'm not sure how it would? Anyhow, putting this out there for review.

Brian0255 commented 1 year ago

Not much you can do about sharing violations, which are the most common cause of an issue on Windows. I believe the error occurs because BizHawk is using a file (often an image) and then Windows tries to overwrite it, but it doesn't have permission to since BizHawk is using the file. As a result, it throws a sharing violation and people end up having a mix of old/new files.

Both trackers suffer from this issue (and there's not really anything we can do about it) so I wouldn't worry about it. If anything it's just a good case for not throwing out releases super frequently.

With that said, I don't think that really needs to be the goal of this PR. The main thing is having an auto-updater at ALL for Linux, which I think you very much succeeded in. Thanks for putting this together!

wesleystedman commented 1 year ago

As far as I'm aware, sharing violations aren't really a thing on Linux, so unless mono is emulating that behavior somehow, I don't think it would happen. I didn't test thoroughly for that, but I know it had to be using the favorites images, and those had no problems that I encountered.