search

Brian393 / petropolis

GNU General Public License v3.0
5 stars 2 forks source link

Video improvements (overlay on map and sidebar data display) #107

Closed Brian393 closed 4 years ago

Brian393 commented 4 years ago

THESE CHANGES CAN BE MADE AFTER EDITING TOOLS WORK PROPERLY

  1. We have talked about improving the ability for users to add videos with the editing tools. The idea is to use some regEx script to convert the URL that the user finds in the browser bar to an address that is usable by the app (see URL.js). -- A Vimeo address like "https://vimeo.com/196500132" would be transformed into "https://player.vimeo.com/video/196500132". -- A YouTube address such as "https://www.youtube.com/watch?v=rfVCKXnZu58" would be transformed into "https://www.youtube-nocookie.com/embed/rfVCKXnZu58".

  2. While doing this, it would be good improve the data table names so that they are clear for the users. Currently I am displaying video as a map overlay from a table called video_pipelines, which has a column called "vimeoSrc" and another one called "vimeoTitle". These should be renamed to "videoSrc" and "caption", in order to avoid confusion.

  3. Currently, however, "caption" will not display anything when a video is played, because this function is not set up in Map.vue. So that function should be written out, just as it is for the AppLightBox image arrays, where each image displays a caption.

  4. Another important functionality is the possibility to show a video in the sidebar data display. Just as we now have an imageUrl function in SidePanel.vue, connected to an imageUrl reference in the data table, we should also have a videoURL function. Any time this column is present with a non-null value, a video appears along with the rest of the data display. The video could be shown in an iFrame (I tried that and it does work). In that case we would have to put a whole iFrame embed code into the videoURL column. But it would probably be better to use the lightbox here too. If the lightbox can be used, then the regEx script for URL conversion can be used here too.

Brian393 commented 4 years ago

Done except for caption in sidebar