search

BrianBunker / cmv-widgets

Widgets based on the Esri jsapi, configured for the Configurable Map Viewer. Widgets include Drag and Drop, Goto, Map Navigation Hash, and Nearby.
https://brianbunker.github.com/cmv-widgets
MIT License
18 stars 24 forks source link

Adding shape files #30

Closed deepal13 closed 8 years ago

deepal13 commented 8 years ago

Hi,

I tried adding the shape files you have provided but it doesn't seem to work. Can you please check?

Thanks

BrianBunker commented 8 years ago

@deepal13 Thanks for your interest in the DnD widget! I successfully downloaded the sample shapefiles and dragged-and-dropped them onto the sample application. I'm closing this issue until a deficiency can be verified.

deepal13 commented 8 years ago

Hi Brian,

Thank you for your prompt response.

Yes, it is working in the sample application you just sent but it is not working in http://brianbunker.github.io/cmv-widgets/.

I downloaded the project from GitHub and it doesn't seem to work there as well.

Thanks

BrianBunker commented 8 years ago

Reopening due to to confirmed deficiency. Thanks for the clarification!

deepal13 commented 8 years ago

Hi Brian, I copied the scripts from https://github.com/BrianBunker/dojo-esri-dnd-widget for DnD part and everything works fine now.

Thanks.

BrianBunker commented 8 years ago

Good to hear. I'm keeping this issue open so I can remember to get it working in this repo too.

irisevenstar commented 8 years ago

deepal13 - do you have something that is working for both shapefiles and kml, or just shapefiles? The code in the repo you pointed to appears to just work with shapefiles.

tmcgee commented 8 years ago

@irisevenstar The code in this cmv-widgets repo supports both shapefiles and kml. I am the one that added kml support. no support for kmz files currently.

irisevenstar commented 8 years ago

@tmcgee - I guess my question was whether what @deepal13 downloaded supported kml, since the shapefile functionality in this repo isn't working at the present time.

tmcgee commented 8 years ago

@irisevenstar I'm pretty sure that the comment related to the demo application here: http://brianbunker.github.io/cmv-widgets/. The code in this repo does work, just not in that demo.

irisevenstar commented 8 years ago

I don't think the shapefile code works, either in the repo or the demo. I'm experiencing the same issue in my own application using the repo code as is present in the demo where the shapefile doesn't appear on the map despite being zoomed to the area and showing up in the table of contents for the DnD widget.

tmcgee commented 8 years ago

@irisevenstar I see what you mean. Sorry, I misinterpreted the prior discussion. I am working on a Pull Request to fix this.

irisevenstar commented 8 years ago

@tmcgee Thank you. Everything appears to be working perfectly now.