I have a repository. I need approvals from 2 teams (team A and team B). I have my configuration:
groups:
teamA:
members:
member1
member2
required: 1
teamB:
members:
member3
member4
required: 1
AND
name: Require User Approval
on:
pull_request_review:
types: [editted, submitted]
jobs:
require_user_approval:
name: Require User Approval
runs-on: ubuntu-latest
steps:
name: Request review based on files changes and/or groups the author belongs to
uses: briancarnold/requireuserapproval@debug28
with:
token: ${{ secrets.TESTING_SECRET }}
Expected behavior: On every pull request I need 1 approval from team A and one approval from team B (it shouldn't work when I have 2 approvals from e.g. member3 and member4).
How it works?: I can merge my changes without approvals from Team A and Team B (members 1-4). The action is not running automatically when I'm creating pull request. When I add a comment, the action is running but I can still merge my changes without approvals.
Dear Colleagues,
I have a repository. I need approvals from 2 teams (team A and team B). I have my configuration:
groups: teamA: members:
AND
name: Require User Approval
on: pull_request_review: types: [editted, submitted]
jobs: require_user_approval: name: Require User Approval runs-on: ubuntu-latest steps:
Expected behavior: On every pull request I need 1 approval from team A and one approval from team B (it shouldn't work when I have 2 approvals from e.g. member3 and member4).
How it works?: I can merge my changes without approvals from Team A and Team B (members 1-4). The action is not running automatically when I'm creating pull request. When I add a comment, the action is running but I can still merge my changes without approvals.
Can you help me? Am I missing something?
Thanks in advance, Damian