Program SDS Special positions convert incorrectly

BrianGarland / vscode-rpgfree

Visual Studio Code extension to convert fixed format RPGLE to free format

MIT License

18 stars 11 forks source link

Program SDS Special positions convert incorrectly #62

Open m-tyler opened 1 year ago

m-tyler commented 1 year ago

V0.0.24

Converting DS of PGM SDS/INFDS. This example happens to be for an INFDS but I have run into this issue with PSDS also. My company has a common PSDS and INFDS /COPY members, so this is a low PTY for me at least.

Before

     D INFDS           DS
     D  STATUS           *STATUS

After

       Dcl-DS INFDS;
         STATUS         Char(NaN)  Pos(TUS);
        End-DS;

Correct conversion

        Dcl-DS INFDS;
          STATUS         *STATUS;
        End-DS;

BrianGodsend commented 1 year ago

Sorry for my multiple commits related to this issue. I kept thinking I was doing something wrong in my commit message as the issues were linked, but not closed. I think linking to an issue will auto-close only if you are the creator of the issue. So, the pull request #79 from the BrianGodsend/vscode-rpgfree fork does fix this issue.