search

BrianGladman / mpir

Multiple Precision Integers and Rationals
GNU General Public License v3.0
75 stars 36 forks source link

Invalid dll_mpir_skylake_avx.vcxproj file generated #16

Closed 7ofNine closed 4 years ago

7ofNine commented 4 years ago

When generating the solution and project filed under VS19 for skylake_avx a project file is generated that is not readable by VS 2019. There are many entries of the type

and similar, which are rejected by VS having bad syntax.

BrianGladman commented 4 years ago

My last change to mpir_config.py introduced a bug which I have now corrected. It should work now.

7ofNine commented 4 years ago

Unfortunately it doesn’t work, yet. Attached what is being generated.

If I fall back to “dcbd4ddc58b7a10f54e494fb05338365ee8d15ff” it is working.

From: Brian Gladman [mailto:notifications@github.com] Sent: November-02-19 4:12 PM To: BrianGladman/mpir Cc: 7ofNine; Author Subject: Re: [BrianGladman/mpir] Invalid dll_mpir_skylake_avx.vcxproj file generated (#16)

My last change to mpir_config.py introduced a bug which I have now corrected. It should work now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BrianGladman/mpir/issues/16?email_source=notifications&email_token=AC3WTWGMZUCCH4SB3E7XUG3QRXNHLA5CNFSM4JIHHPA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5D7MI#issuecomment-549076913 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3WTWDRWUY5U6OLW4LW353QRXNHLANCNFSM4JIHHPAQ .Image removed by sender.

BrianGladman commented 4 years ago

That is odd as it is now working fine for me. I could not find any attachment to look at so I don't know what is now going wrong for you.

7ofNine commented 4 years ago

I ‘ll do a sync and try again.

From: Brian Gladman [mailto:notifications@github.com] Sent: November-02-19 5:42 PM To: BrianGladman/mpir Cc: 7ofNine; Author Subject: Re: [BrianGladman/mpir] Invalid dll_mpir_skylake_avx.vcxproj file generated (#16)

That is odd as it is now working fine for me. I could not find any attachment to look at so I don't know what is now going wrong for you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BrianGladman/mpir/issues/16?email_source=notifications&email_token=AC3WTWFKFUJXUQ525MRECUDQRXX3XA5CNFSM4JIHHPA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5FVII#issuecomment-549083809 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3WTWCQVUIYMLP7GYLUH2TQRXX3XANCNFSM4JIHHPAQ .Image removed by sender.

7ofNine commented 4 years ago

It works fine know. I must have picked up somehow the wrong files. Thanks for the fix