search

BrianGladman / mpir

Multiple Precision Integers and Rationals
GNU General Public License v3.0
75 stars 36 forks source link

Feature/fix vs17 builds #18

Closed P-N-L closed 4 years ago

P-N-L commented 4 years ago

Hello Brian,

I am working on scripted installs of some libraries using MS Build Tools 2017 (as a toolset from the MS Build Tools 2019 installer). I needed to make these adjustments for the existing VS17 files to work properly. Please let me know if you have any questions or would like help extending the changes to the other VS versions.

Thanks! Nick

BrianGladman commented 4 years ago

Thanks for the documenting your changes, it helps a lot in looking through them. I will merge the pull request. On the delayed expansion issue I too have seen this issue but it is unclear why it only seem to fail without this in some situations and not in others.

BrianGladman commented 4 years ago

On extending the changes to other versions, I won't be able to do this on earlier Visual Studio versions as I no longer use them and cannot hence test any changes. I am only actively maintaining the VS 2019 code and I will look at bringing the changes in here. But I have a bigger problem with msbuild.bat in the VS2019 build at the moment in that it fails because it doesn't read the results of vswhere properly. And I haven't found a solution :-(

P-N-L commented 4 years ago

Thank you! Now that I am passing in msbdir manually I do not need vswhere to work for my case, but before then, I did manage to get it to work using the expansion code (it should still work the way I pushed it). That may be at least part of what you need!

I am trying to get our project to 2017 right now, but hope to get to 2019 relatively soon. If I get there and you still need help, I will do what I can!

Best, Nick