search

BrianGrug / PerPlayerServers

Create Minecraft servers with Docker
MIT License
8 stars 2 forks source link

Several improvements and cleanups of the code and others. #1

Closed 0rangeFox closed 2 years ago

0rangeFox commented 3 years ago

Hey, here are some improvements I have already made, and I hope you like them.

BrianGrug commented 3 years ago

Thank you! I'll review it when I'm home!

0rangeFox commented 3 years ago

It hasn't been tested yet, but I would like you to do it yourselves, because I don't have those tools right now.

BrianGrug commented 3 years ago

Hey I have one more commit to push then me and Invis will finish reviewing it!

0rangeFox commented 3 years ago

Ok, so push that commit and I'll implement that code right away or improve it if necessary.

BrianGrug commented 3 years ago

Sounds good, just pushed. The only thing I can really say is just try to make use of Lombok!

0rangeFox commented 3 years ago

You pushed to another branch, are you not mistaken?

BrianGrug commented 3 years ago

Sorry, just merged it

0rangeFox commented 3 years ago

There, I think it's all straight and now just give it a review.

BrianGrug commented 3 years ago

Just waiting for @InvisRaidinq to review too!